ediff frames not handled correctly

[Dan Nicolaescu]

Try:

emacs -q
M-x ediff RET SOMEFILE RET SOMEOTHERFILE RET

now with the mouse on the small ediff control frame type ? twice.
Normally the help frame be shown and then deleted, but it is not
deleted.
This does not happen with the CVS HEAD.

Does anyone have any idea what is going on?

Thanks
--dan

[Daniel 'NebuchadnezzaR' Dehennin]

Post by Dan Nicolaescu
emacs -q
M-x ediff RET SOMEFILE RET SOMEOTHERFILE RET
now with the mouse on the small ediff control frame type ? twice.
Normally the help frame be shown and then deleted, but it is not
deleted.
This does not happen with the CVS HEAD.

I have problems too with ediff, trying to quit the control frame give
the following error:

ediff-cleanup-mess: Attempt to delete minibuffer or sole ordinary window

Regards.

[Károly Lőrentey]

Post by Daniel 'NebuchadnezzaR' Dehennin
I have problems too with ediff, trying to quit the control frame give
ediff-cleanup-mess: Attempt to delete minibuffer or sole ordinary window

Could you test to see if patch-528 fixed this for you?

Thanks,

[Daniel 'NebuchadnezzaR' Dehennin]

Post by Károly Lőrentey
Could you test to see if patch-528 fixed this for you?

Arff, I'm a lasy man, I use your debian package :-)

[Károly Lőrentey]

Post by Daniel 'NebuchadnezzaR' Dehennin

Post by Károly Lőrentey
Could you test to see if patch-528 fixed this for you?

Arff, I'm a lasy man, I use your debian package :-)

Ah, but that's no excuse, I have just uploaded the .debs for
patch-531. :-)

[Daniel 'NebuchadnezzaR' Dehennin]

Post by Károly Lőrentey
Ah, but that's no excuse, I have just uploaded the .debs for
patch-531. :-)

Ok, I install the latest version and it work well now.

Thanks a lot, since I discover Ediff I wonder how I lived without
before :-)

[Puneet]

Tried with emacs--multi-tty--0--patch-531. It works.

Thanks & Regards
Puneet

Post by Károly Lőrentey

Post by Daniel 'NebuchadnezzaR' Dehennin
I have problems too with ediff, trying to quit the control frame give
ediff-cleanup-mess: Attempt to delete minibuffer or sole ordinary window

Could you test to see if patch-528 fixed this for you?
Thanks,
--
K?roly
_______________________________________________
multi-tty mailing list
multi-tty at lists.fnord.hu
http://lists.fnord.hu/mailman/listinfo/multi-tty

[Károly Lőrentey]

Post by Dan Nicolaescu
emacs -q
M-x ediff RET SOMEFILE RET SOMEOTHERFILE RET
now with the mouse on the small ediff control frame type ? twice.
Normally the help frame be shown and then deleted, but it is not
deleted.

I finally tracked down this and some other (less critical)
ediff-related bugs:

(1) `make-frame' could inadvertently change the current buffer
due to an oversight in the `with-selected-frame' macro.
This messed up the `ediff-control-frame' variable, so
Ediff forgot about existing control frames, and kept
recreating new ones. This is the bug you describe.

(2) The visibility declaration in (make-frame '((visibility . nil)))
did not immediately take effect due to a bug in CVS. The
frame was created visible, then made invisible later,
resulting in annoying flicker. I fixed this directly in
CVS.

(3) Ediff looked at `window-system' at load-time to choose
between its single-frame and multi-frame layouts. This
fails when multiple terminal types are used in the same
session. I introduced the function
`ediff-setup-windows-automatic' for dynamic window-system
detection.

Note that the fix for (1) changes a macro, so you'll need to do a
bootstrap for it to take effect.