patch-598 broken

[Ami Fischman]

As of today, grabbing a fresh archive with:
baz grab http://lorentey.hu/grab/multi-tty

and building with:
../multi-tty/configure --without-gtk --build=i686-gnu-linux-gnu
--with-x-toolkit=lucid --with-xpm --with-jpeg --with-tiff --with-gif
--with-png --with-x && make bootstrap

Fails with:
gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I.
-I.../multi-tty/src -D_BSD_SOURCE -I/usr/include/alsa -g -O2
-Wno-pointer-sign ...multi-tty/src/xterm.c
...multi-tty/src/xterm.c: In function 'x_scroll_bar_expose':
...multi-tty/src/xterm.c:5311: error: 'struct x_output' has no member named
'foreground_pixel'
make[2]: *** [xterm.o] Error 1

Looks like line 5311 really wants to be accessing FRAME_FOREGROUND_PIXEL(f)
?

BTW, did GTK become safe to use with multi-tty recently?

Cheers,
-Ami
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.fnord.hu/pipermail/multi-tty/attachments/20070225/6c122df4/attachment.htm

[Manoj Srivastava]

As of today, grabbing a fresh archive with: baz grab
http://lorentey.hu/grab/multi-tty
and building with: ../multi-tty/configure --without-gtk
--build=i686-gnu-linux-gnu --with-x-toolkit=lucid --with-xpm
--with-jpeg --with-tiff --with-gif --with-png --with-x && make
bootstrap

,----
| __> baz tree-id
| lorentey at elte.hu--2004/emacs--multi-tty--0--patch-598
| ./configure --without-gtk --with-pop=yes --with-xpm --with-jpeg
| --with-tiff --with-gif --with-png --with-x --with-x-toolkit=lucid
| make bootfast
`----

Seems to have worked fine for me.

manoj

[Manoj Srivastava]

Hi,

Does this work for you in a clean checkout dir? Does it work with
bootstrap (the target I used, not bootfast)? I suspect that the
reason it works for you is that the buggy xterm.c isn't being
re-examined, only your elisp files recompiled.

Yes. I don't like building in my baz checkout tree, sinc I
don't know what that might affect. I generally copy the fresh
checkout, which has never been built, into a build dir. run
make maintainer-clean
and then run my script, which does
,----
| ./configure --without-gtk --with-pop=yes --with-xpm --with-jpeg
| --with-tiff --with-gif --with-png --with-x --with-x-toolkit=lucid
| make bootfast
`----

I sometimes merge from the latest CVS emacs into the build
tree (when the multi-tty branch has seen no activity for a period,
and i want to play with the latest patches), which is why my script
does make bootfast.

But every time the multi-tty branch is refreshed, I start with
a clean tree.

I have put up a build log from my latest attempt on:

http://people.debian.org/~srivasta/multi-tty-build.log.bz2

This is mostly a straight multi-tty branch, with a minimal set of
Debian related patches applied, which add in the debian flavor
symbol, and change default dir settings to match how Debian lays
them out. No patches applied to xterm.* at all.

__> baz diff lorentey at elte.hu--2004/emacs--multi-tty--0 | diffstat
etc/NEWS | 5
etc/emacs.1 | 20
lisp/gnus/message.el | 9
lisp/startup.el | 17
lisp/vc-hooks.el | 4
lisp/version.el | 4


manoj

[Ami Fischman]

The reason it worked for you is that you have the xaw3d toolkit installed so
the scrollbar is enabled (so the alleged bug in xterm.c is ifdef'd out).
apt-get'ing xaw3dg-dev gets configure to decide to use toolkit scroll bars
for me too and the problem goes away. But I think this is a bug in emacs
(which only surfaces when toolkit scrollbars are not used).

-a

Post by Manoj Srivastava
Hi,

Does this work for you in a clean checkout dir? Does it work with
bootstrap (the target I used, not bootfast)? I suspect that the
reason it works for you is that the buggy xterm.c isn't being
re-examined, only your elisp files recompiled.

Yes. I don't like building in my baz checkout tree, sinc I
don't know what that might affect. I generally copy the fresh
checkout, which has never been built, into a build dir. run
make maintainer-clean
and then run my script, which does
,----
| ./configure --without-gtk --with-pop=yes --with-xpm --with-jpeg
| --with-tiff --with-gif --with-png --with-x --with-x-toolkit=lucid
| make bootfast
`----
I sometimes merge from the latest CVS emacs into the build
tree (when the multi-tty branch has seen no activity for a period,
and i want to play with the latest patches), which is why my script
does make bootfast.
But every time the multi-tty branch is refreshed, I start with
a clean tree.
http://people.debian.org/~srivasta/multi-tty-build.log.bz2
This is mostly a straight multi-tty branch, with a minimal set of
Debian related patches applied, which add in the debian flavor
symbol, and change default dir settings to match how Debian lays
them out. No patches applied to xterm.* at all.
__> baz diff lorentey at elte.hu--2004/emacs--multi-tty--0 | diffstat
etc/NEWS | 5
etc/emacs.1 | 20
lisp/gnus/message.el | 9
lisp/startup.el | 17
lisp/vc-hooks.el | 4
lisp/version.el | 4
manoj
--
America has been discovered before, but it has always been hushed
up. Oscar Wilde
Manoj Srivastava <srivasta at acm.org> <http://www.golden-gryphon.com/>
1024D/BF24424C print 4966 F272 D093 B493 410B 924B 21BA DABB BF24 424C

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.fnord.hu/pipermail/multi-tty/attachments/20070226/85f8d17d/attachment.htm

[Xavier Maillard]

Looks like line 5311 really wants to be accessing FRAME_FOREGROUND_PIXEL(f) ?

It also failed here with same configure option.

BTW, did GTK become safe to use with multi-tty recently?

Dunno.

Oh and it is on a slackware GNU/linux 11.0 system.

Xavier

[Xavier Maillard]

Post by Xavier Maillard

Looks like line 5311 really wants to be accessing FRAME_FOREGROUND_PIXEL(f) ?

It also failed here with same configure option.

Gotcha ! It works when I am building (make bootstrap) as root user
!

I am really lost at it now :/

Xavier

[Karoly Lorentey]

Post by Ami Fischman
...multi-tty/src/xterm.c:5311: error: 'struct x_output' has no member
named 'foreground_pixel'
make[2]: *** [xterm.o] Error 1
Looks like line 5311 really wants to be accessing
FRAME_FOREGROUND_PIXEL(f) ?

Yes, you're right. I'll fix this the next time I get to my Linux box.

Post by Ami Fischman
BTW, did GTK become safe to use with multi-tty recently?

Not really, although GTK+ 2.10 seems much better. I enabled multiple X
display support for GTK simply because Richard asked me to that. (See
the recent multi-tty discussion on emacs-devel.)
--
Karoly

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://lists.fnord.hu/pipermail/multi-tty/attachments/20070227/c2727e8b/attachment.pgp